feat(stovepipe): add Queue.LastGreenRequestID in Stovepipe Queue - #518
Merged
roychying merged 1 commit intoAug 7, 2026
Merged
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 5, 2026 22:07
mnoah1
approved these changes
Aug 6, 2026
mnoah1
force-pushed
the
chenghan.ying/stovepipe-queue-last-green-request-id
branch
from
August 6, 2026 18:51
5615d8f to
c2af1d5
Compare
roychying
force-pushed
the
chenghan.ying/stovepipe-queue-last-green-request-id
branch
2 times, most recently
from
August 7, 2026 01:16
0b9bd3a to
bbe75df
Compare
…ark can only move forward
roychying
force-pushed
the
chenghan.ying/stovepipe-queue-last-green-request-id
branch
from
August 7, 2026 01:19
bbe75df to
1c760ed
Compare
behinddwalls
deleted the
chenghan.ying/stovepipe-queue-last-green-request-id
branch
August 7, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
recordstage advances the queue's last-green bookmark, and that bookmark must only ever move forward.entity.Queuetoday carriesLastGreenURIbut no record of which request established it, so there is nothing to compare a candidate against — a late-arriving delivery for an older request could regress the bookmark to a stale commit, whichprocesswould then hand tobuildas an incremental baseline.Adding the owning request id gives the guard something to compare, using the same ingest-order comparison (
CompareRequestID) thatingestandprocessalready use for coalescing.What?
entity.QueuegainsLastGreenRequestID, paired with the existingLastGreenURI.queueStorethreads it throughCreate,Get, andUpdate.schema/queue.sqlgainslast_green_request_id VARCHAR(255) NOT NULL DEFAULT '', so existing rows read back as "bookmark never set" and the first green outcome adopts unconditionally.Test Plan
make gazelle, make build, make test - all clean
Issue