refactor(orchestrator): accept entity.GetTargetGraphRequest in orchestrator.GetTargetGraph#187
Open
yushan8 wants to merge 2 commits into
Open
refactor(orchestrator): accept entity.GetTargetGraphRequest in orchestrator.GetTargetGraph#187yushan8 wants to merge 2 commits into
entity.GetTargetGraphRequest in orchestrator.GetTargetGraph#187yushan8 wants to merge 2 commits into
Conversation
3 tasks
2 tasks
yushan8
force-pushed
the
entity/wire-mapper-callsites
branch
2 times, most recently
from
b55447f to
9682039
Compare
yushan8
changed the base branch from
entity/domain-types
to
entity/mapper-cache-keys
yushan8
force-pushed
the
entity/mapper-cache-keys
branch
from
18d425d to
1ef0530
Compare
yushan8
force-pushed
the
entity/wire-mapper-callsites
branch
from
9682039 to
cf53dc9
Compare
yushan8
force-pushed
the
entity/mapper-cache-keys
branch
from
1ef0530 to
69e5210
Compare
yushan8
force-pushed
the
entity/wire-mapper-callsites
branch
from
cf53dc9 to
22db6e8
Compare
yushan8
force-pushed
the
entity/mapper-cache-keys
branch
from
69e5210 to
c4b913a
Compare
…ntroller boundaries Move the entity type one layer further up the call chain: orchestrator.GetTargetGraphParam.Req and controller.getGraph now take entity.GetTargetGraphRequest directly. Proto requests are converted to entity types exactly once, at the RPC boundary (controller.GetTargetGraph, controller.GetChangedTargets' fan-out), so the inline mapper.ProtoToBuildDescription conversions added in the previous commit become redundant downstream and are removed. No entity->proto bridge is ever needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…etGraphRequest directly GetTargetGraphParam only wrapped entity.GetTargetGraphRequest plus a BypassCache field that always mirrored req.BypassCache at the only call site. Orchestrator.GetTargetGraph now takes entity.GetTargetGraphRequest directly, removing the redundant wrapper type. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yushan8
force-pushed
the
entity/wire-mapper-callsites
branch
from
741f674 to
d896b91
Compare
This was referenced Jul 13, 2026
yushan8
changed the title
orchestrator.GetTargetGraph
yushan8
changed the title
orchestrator.GetTargetGraphentity.GetTargetGraphRequest in orchestrator.GetTargetGraph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Orchestrator.GetTargetGraphnow takesentity.GetTargetGraphRequestdirectly (theGetTargetGraphParamwrapper is removed — it only ever wrapped the request plus a redundantBypassCachefield), converted once at the boundary viamapper.ProtoToGetTargetGraphRequestincontroller.GetTargetGraph.internal/mapper's proto→entity conversions an actual caller and keeps theOrchestratorinterface transport-agnostic.native_orchestrator.goconsumes entity fields directly throughout — no entity->proto bridge is introduced or ever needed, sinceRepoManager.Leaseand the cache-path helpers were already made entity-typed in refactor(mapper): move cache-path helpers into internal/mapper #193/refactor(repomanager): entity-type RepoManager.Lease #192.Test plan
go build ./...go test ./core/common/... ./core/repomanager/... ./orchestrator/... ./controller/... ./internal/mapper/...bazel build/bazel teston the same packagesmake gazellegrep -rn "buildDescriptionToProto\|computationStrategyToProto"returns nothingStack (bottom to top):
entity.GetTargetGraphRequestinorchestrator.GetTargetGraph#187