Skip to content

refactor: migrate callsites to entity types and consolidate config#212

Draft
yushan8 wants to merge 1 commit into
yushan/streaming-and-mappersfrom
yushan/migrate-callsites
Draft

refactor: migrate callsites to entity types and consolidate config#212
yushan8 wants to merge 1 commit into
yushan/streaming-and-mappersfrom
yushan/migrate-callsites

Conversation

@yushan8

@yushan8 yushan8 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Orchestrator interface now returns *mapper.GraphChunkReader instead of storage.GraphReader, removing proto leakage from the orchestrator layer
  • Controller reads entity.GraphChunk internally, converting to proto via mapper.GraphChunkToProto only at send time
  • Controller changed-targets path uses streaming.SplitBySize and streaming.SplitMetadata for chunking
  • Consolidates service.streaming.{max_num_targets,...} into a single service.max_message_bytes field (DefaultMaxMessageBytes = 4,250,000)
  • Removes old chunking code from core/common (ResultToGetTargetGraphResponse, ChunkMetadata, chunkTargets, splitMap, and associated constants/tests)
  • Updates query-bench to use mapper.ResultToGraphChunks

Stack

Test plan

  • make build passes
  • make test — all 19 test targets pass
  • make gazelle — BUILD files in sync
  • Controller tests updated to use newGraphChunkReaderFromProto helper
  • Orchestrator tests updated for new GraphChunkReader return type
  • Orchestrator mock regenerated

@yushan8
yushan8 requested review from a team as code owners July 17, 2026 03:57
@yushan8
yushan8 marked this pull request as draft July 17, 2026 04:11
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from 9bd4bdf to d05117c Compare July 17, 2026 05:13
@yushan8
yushan8 force-pushed the yushan/migrate-callsites branch from 94857f0 to 042586a Compare July 17, 2026 05:13
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from d05117c to 7025afd Compare July 17, 2026 16:10
@yushan8
yushan8 force-pushed the yushan/migrate-callsites branch from 042586a to c367538 Compare July 17, 2026 16:10
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from 7025afd to ecb2996 Compare July 17, 2026 17:08
@yushan8
yushan8 force-pushed the yushan/migrate-callsites branch from c367538 to 24ef6fd Compare July 17, 2026 17:08
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from ecb2996 to 36f3f33 Compare July 17, 2026 22:57
@yushan8
yushan8 force-pushed the yushan/migrate-callsites branch 2 times, most recently from 36f5b20 to 89506ef Compare July 17, 2026 23:07
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from 36f3f33 to 91d9a76 Compare July 17, 2026 23:07
@yushan8
yushan8 force-pushed the yushan/migrate-callsites branch from 89506ef to 194fded Compare July 17, 2026 23:32
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from 91d9a76 to 9e0abdd Compare July 17, 2026 23:32
- Orchestrator interface returns *mapper.GraphChunkReader instead of
  storage.GraphReader, removing proto leakage from the orchestrator layer
- Controller uses mapper.GraphChunkToProto at send time, streaming
  entity.GraphChunk internally
- Controller changed-targets path uses streaming.SplitBySize and
  streaming.SplitMetadata for chunking
- Consolidate service.streaming.{max_num_targets,...} into single
  service.max_message_bytes (DefaultMaxMessageBytes = 4,250,000)
- Remove old chunking code from core/common (ResultToGetTargetGraphResponse,
  ChunkMetadata, chunkTargets, splitMap, and associated constants)
- Update query-bench to use mapper.ResultToGraphChunks
- Regenerate orchestrator mock for new return type

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yushan8
yushan8 force-pushed the yushan/migrate-callsites branch from 194fded to cb43482 Compare July 18, 2026 00:23
@yushan8
yushan8 force-pushed the yushan/streaming-and-mappers branch from 9e0abdd to b621c93 Compare July 18, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant