Skip to content

Fix: Don't disconnect signals on cancel before the session actually ends - #223

Merged
robert-ancell merged 1 commit into
ubuntu:mainfrom
wolneykien:announce/cancelling
Nov 20, 2022
Merged

Fix: Don't disconnect signals on cancel before the session actually ends#223
robert-ancell merged 1 commit into
ubuntu:mainfrom
wolneykien:announce/cancelling

Conversation

@wolneykien

Copy link
Copy Markdown

Otherwise, no completion message is sent to the greeter leaving it in the in_authentication state.

@github-actions

github-actions Bot commented Jan 12, 2022

Copy link
Copy Markdown

Everyone contributing to this PR have now signed the CLA. Thanks!

@wolneykien
wolneykien force-pushed the announce/cancelling branch 3 times, most recently from 8ca6597 to c647d4c Compare April 27, 2022 14:01
@wolneykien

Copy link
Copy Markdown
Author

@robert-ancell , don't you know how can I reproduce the failing tests? The branch is building normally and all tests are passed — at least, in ununtu:rolling Docker container… The same thing with the patch rebased on main.

@robert-ancell

Copy link
Copy Markdown
Collaborator

@robert-ancell , don't you know how can I reproduce the failing tests? The branch is building normally and all tests are passed — at least, in ununtu:rolling Docker container… The same thing with the patch rebased on main.

I've pushed a fix to main that fixes a compile warning that was being treated as an error on Fedora. But you will also need to rebase on main to pick up some other test fixes.

@robert-ancell

Copy link
Copy Markdown
Collaborator

@wolneykien are you planning on rebasing this?

@wolneykien

Copy link
Copy Markdown
Author

Yes, Robert. I forgot about the issue. Let me done that, say, in a couple of days..?

Otherwise, no completion message is sent to the greeter leaving it in
the 'in_authentication' state

Signed-off-by: Paul Wolneykien <manowar@altlinux.org>
@robert-ancell
robert-ancell merged commit cac805d into ubuntu:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants