Honor vncserver command on start and other fixes. - #265
Merged
robert-ancell merged 3 commits intoAug 26, 2022
Conversation
Fixes ubuntu#264. * src/lightdm.c (start_display_manager): Validate if the VNCServer command provided binary is available; fallback to 'Xvnc' otherwise.
When providing the VNCServer command as 'Xvnc -SecurityTypes None', the formatted command line used would look like: Xvnc -SecurityTypes None :1 -auth /var/run/lightdm/root/:1 which is invalid (the display number must appear first). * src/x-server-local.c (x_server_local_start): Format the command placing the display number before any other provided arguments.
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
There is no longer support for 8 bit color depth in TigerVNC (see: TigerVNC/tigervnc@e86d872); using it causes a fatal error. * src/x-server-xvnc.c (x_server_xvnc_init): Set default depth to 24 bit. * tests/scripts/vnc-command.conf (command): Adjust accordingly. * tests/scripts/vnc-guest.conf (user-session): Likewise. * tests/scripts/vnc-login.conf (user-session): Likewise. * tests/scripts/vnc-open-file-descriptors.conf (user-session): Likewise. * data/lightdm.conf: Likewise.
apteryks
force-pushed
the
honor-vncserver-command-on-start
branch
from
August 11, 2022 15:57
02e3d25 to
3a66b9c
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, the feature works for me using the latest TigerVNC release (1.12.0).