Fix Fedora and Ubuntu GitHub workflow tests, and other test/CI improvements - #301
Merged
Conversation
Contributor
Author
Ah ha! |
This silences some warning messages on Fedora.
Starting with dbus-daemon v1.15.2, unix:tmpdir no longer causes dbus-daemon to create abstract sockets (for security reasons), so unix:tmpdir is now equivalent to unix:dir. (Also, some systems don't support abstract sockets.) Switch to unix:dir so that it is clear that the tests expect a socket file to be created in the filesystem.
The Ubuntu tests were disabled in commit 40c3b4d because they were failing. They are working now.
This makes the errors much easier to find vs. downloading the zip artifact and extracting it.
rhansen
changed the title
Collaborator
|
Thanks @rhansen! I've never managed to find the time to fix this bitrot, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important commits are:
/tmp/dbus-*to$LIGHTDM_TEST_ROOT/tmp/dbus-*The first of those two commits fixes the
test.yamlGitHub workflow for both Fedora and Ubuntu. I don't know whydbus-daemonis creating a Unix domain socket in the filesystem instead of creating an abstract socket. Maybe some security policy is preventing abstract sockets from working in Docker on the runner?The remaining commits are test/CI tweaks I made while troubleshooting that I thought were worth including.
Please do not squash this when merging—the commits are intended to be separate. I will rebase these as needed to incorporate feedback or update to the latest
main.