Skip to content

xserver: fix incorrect format and x addr maybe null - #449

Open
GermanAizek wants to merge 1 commit into
ubuntu:mainfrom
GermanAizek:fix-incorrect-format-1
Open

xserver: fix incorrect format and x addr maybe null#449
GermanAizek wants to merge 1 commit into
ubuntu:mainfrom
GermanAizek:fix-incorrect-format-1

Conversation

@GermanAizek

Copy link
Copy Markdown
Contributor

x_server_get_address (server) may return NULL this dangerous since many functions may not check the input parameters for NULL

Affected funcs with maybe NULL parameter:

  • l_debug
  • xcb_connect_to_display_with_auth_info

@GermanAizek

Copy link
Copy Markdown
Contributor Author

This cannot be fixed added check on NULL because g_strdup_printf(), g_snprintf() function belong to Glib.
l_debug fix He'll be here #451

@JPeisach

JPeisach commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

No, like, if the server address is NULL then there is no server... so no connection should be attempted at that point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants