Quote mirror script path expansions in mirror docs#698
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Quote mirror script path expansions in mirror docs
Jul 8, 2026
utkarsh2102
approved these changes
Jul 8, 2026
utkarsh2102
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the two shell script examples in
docs/release-team/mirror-scripts.mdto address the review-thread feedback about incomplete quoting. The snippets now consistently quote path and rsync arguments so the documented examples align with the stated shell-safety expectations.Archive mirror example
BASEDIRin the directory existence check andmkdir -pRSYNCSOURCEandBASEDIRin the tworsyncinvocationsRelease mirror example
mkdir -p,rsync, and trace-file redirectExample
Related issue
Addressed via the linked PR review thread.
Checklist
Additional notes (optional)
This change is intentionally limited to the two reviewed documentation snippets and does not modify unrelated content on the page.
Thank you for contributing to the Ubuntu Project documentation!