Conversation
…ke typical vue code
| byte[] secretkey = GetSecretKey(keystring); | ||
|
|
||
| Aes aes = Aes.Create(); | ||
| aes.Mode = CipherMode.ECB; |
Check failure
Code scanning / CodeQL
Encryption using ECB
| using (Aes aes = Aes.Create()) | ||
| { | ||
| // initialize settings to match those used by CF | ||
| aes.Mode = CipherMode.ECB; |
Check failure
Code scanning / CodeQL
Encryption using ECB
bsedwards
approved these changes
Aug 30, 2023
Collaborator
bsedwards
left a comment
There was a problem hiding this comment.
I'm going to approve, but opened an issue about CodeQL alerting on CipherMode.ECB that we can look at later
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CMS components and VIPER database connectivity. Updating packages and dependencies.