Skip to content

CMS#5

Merged
danransom merged 54 commits intomainfrom
Prototype
Aug 30, 2023
Merged

CMS#5
danransom merged 54 commits intomainfrom
Prototype

Conversation

@danransom
Copy link
Copy Markdown
Contributor

Adding CMS components and VIPER database connectivity. Updating packages and dependencies.

@danransom danransom requested a review from bsedwards August 29, 2023 18:57
@danransom danransom self-assigned this Aug 29, 2023
Comment thread web/Areas/CMS/Data/CMS.cs
byte[] secretkey = GetSecretKey(keystring);

Aes aes = Aes.Create();
aes.Mode = CipherMode.ECB;

Check failure

Code scanning / CodeQL

Encryption using ECB

The ECB (Electronic Code Book) encryption mode is vulnerable to replay attacks.
Comment thread web/Areas/CMS/Data/CMS.cs
using (Aes aes = Aes.Create())
{
// initialize settings to match those used by CF
aes.Mode = CipherMode.ECB;

Check failure

Code scanning / CodeQL

Encryption using ECB

The ECB (Electronic Code Book) encryption mode is vulnerable to replay attacks.
Copy link
Copy Markdown
Collaborator

@bsedwards bsedwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve, but opened an issue about CodeQL alerting on CipherMode.ECB that we can look at later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants