Minor adjustments for fixing PR #1186#1212
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you ignore the additional change where I removed ISSUE_FILTER being imported twice (once as FILTER and again as ISSUE_FILTER), there is only one real change.
Before, the
FixIssuesList.jsfile used theInitialSeverityvariable to decide how to compute whether or not to show the "Congratulations! All {initialSeverity} have been resolved." message. But InitialSeverity is only sent on pageload from the summary screen. It's the variable that pre-selects Known or Potential barriers when a user clicks "Resolve" on the summary cards here:But on the Barriers screen, users can change which filter they're using. So now, the currently selected severity is used for showing the same message, based on this guy: