Merged
Conversation
…ency - Add a `planes` property to the SRFFile class to get geometry of SRF - Added `strike_nztm` and `dip_dir_nztm` properties to `Plane` class. - Implemented validation for depth consistency in `Plane.from_centroid_strike_dip`. - Updated tests to cover new properties and validation logic.
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
joelridden
reviewed
Dec 4, 2024
… and dip direction
joelridden
approved these changes
Dec 4, 2024
claudio525
approved these changes
Dec 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements to
Planeclass:strike,strike_nztm,dip_dir, anddip_dir_nztmto thePlaneclass to handle different coordinate systems and bearings. (source_modelling/sources.py) [1] [2]from_centroid_strike_dipmethod to include additional parameters such asstrike_nztmanddip_dir_nztmand added comprehensive validation checks for input consistency. (source_modelling/sources.py) [1] [2]SRF Module:
planesto thesegmentsmethod to extract planes from SRF segments. (source_modelling/srf.py)Test Coverage:
Planeobjects, including failure cases for invalid input combinations and parameter derivations. (tests/test_sources.py) [1] [2] [3]Planeclass and its methods. (tests/test_sources.py) [1] [2] [3]planesproperty. (tests/test_srf.py) [1] [2]