Merged
Conversation
claudio525
reviewed
Nov 27, 2024
claudio525
reviewed
Nov 27, 2024
claudio525
reviewed
Dec 3, 2024
claudio525
reviewed
Dec 4, 2024
- tests check that the plane orientation matches documentation
claudio525
previously approved these changes
Dec 4, 2024
Merged
joelridden
previously approved these changes
Dec 4, 2024
bdd86df
…s import and assertions
Contributor
Author
|
Since the last review:
|
claudio525
approved these changes
Dec 15, 2024
joelridden
reviewed
Dec 16, 2024
Contributor
Author
There was a problem hiding this comment.
sometimes, when the fault is constructed dynamically in the case of the NSHMDB
joelridden
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
source_modelling/sources.pyfile, focusing on refactoring and improving the robustness of the code, as well as adding new tests in thetests/test_sources.pyfile to ensure the correctness of the changes.Refactoring and Improvements:
@staticmethodto@classmethodfor factory methods inPoint,Plane, andFaultclasses, and replaced explicit class names withSelffor better maintainability and readability. [1] [2] [3] [4] [5] [6] [7]Planeclass constructor to validate the input bounds and ensure they form a valid plane.length_mandwidth_mproperties in thePlaneclass to explicitly returnfloatvalues.numpy.typingasnptfor type hinting inPlaneclass constructor.Testing Enhancements:
tests/test_sources.pyto validate thePlaneclass constructor with various invalid inputs, ensuring that the constructor raises appropriate errors.