Update CI - #135
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the repository’s CI configuration into a single reusable GitHub Actions workflow and updates the Python codebase to align with Python 3.12+ typing/CI expectations (including coverage support and minor robustness cleanups).
Changes:
- Replace multiple bespoke GitHub Actions workflows with a single
.github/workflows/ci.ymlthat delegates toucgmsim/meta-ci-actionand enable coverage dependencies/configuration. - Modernize typing across utilities/scripts (PEP 695 generics,
TypeGuard, updated ignore directives) and make timestamps timezone-aware. - Remove in-repo
wiki/markdown documentation and delete the wiki deployment workflow.
Reviewed changes
Copilot reviewed 38 out of 49 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workflow/utils.py | Modernize dict_zip typing using PEP 695 generics; minor recursion fix in merge_dictionaries. |
| workflow/scripts/realisation_to_srf.py | Small return-style/iteration tweak. |
| workflow/scripts/nshm2022_to_realisation.py | Widen dict types via copying for invariant API signatures; update DB call signature. |
| workflow/scripts/migrate.py | Introduce TypeGuard + PEP 695 type alias for configuration class filtering; small cleanups. |
| workflow/scripts/merge_ts.py | Remove shebang line. |
| workflow/scripts/lf_to_xarray.py | Remove shebang line. |
| workflow/scripts/im_calc.py | Narrow KO-dir requirement to FAS only; adjust numeric typing and xarray coord dict style. |
| workflow/scripts/hf_sim.py | Clarify unused computed values (underscore-prefixed) and format string literal grouping. |
| workflow/scripts/generate_velocity_model.py | Replace Optional[...] with `X |
| workflow/scripts/generate_rupture_propagation.py | Remove unused Optional import (typing modernization). |
| workflow/scripts/generate_domain.py | Update ignore-comment style (ty: ignore). |
| workflow/scripts/gcmt_to_realisation.py | Replace Optional[...] with `X |
| workflow/scripts/gcmt_auto_simulate.py | Make workflow ID timestamp tz-aware and local-time formatted. |
| workflow/scripts/create_e3d_par.py | Narrow type annotation for formatting helper. |
| workflow/schemas.py | Remove redundant noqa docstring suppressions; adjust helper type hints. |
| workflow/realisations.py | Use Sequence for coordinate names; remove unused imports; make log timestamps tz-aware. |
| workflow/defaults.py | Adjust import style for default parameters module. |
| tests/test_realisation.py | Update tests for tz-aware timestamps. |
| tests/test_hf.py | Formatting + ignore-comment style updates. |
| tests/test_generate_domain.py | Use literal dicts; ignore-comment style update. |
| tests/test_cli.py | Simplify access to app attribute. |
| pyproject.toml | Add coverage deps to test extras; pin dev tool minimums; configure ty exclusions; deptry config update. |
| uv.lock | Bump dev tools (ruff/ty), add coverage/pytest-cov, refresh markers/metadata. |
| .github/workflows/ci.yml | New consolidated CI entrypoint using ucgmsim/meta-ci-action with coverage enabled. |
| .github/workflows/wiki.yml | Remove wiki deployment workflow. |
| .github/workflows/types.yml | Remove standalone type-check workflow. |
| .github/workflows/test-runner.yml | Remove self-hosted runner “alive” workflow. |
| .github/workflows/ruff.yml | Remove standalone Ruff workflow. |
| .github/workflows/pytest.yml | Remove standalone Pytest/Coverage workflows. |
| .github/workflows/numpydoc.yml | Remove standalone numpydoc lint workflow. |
| .github/workflows/git-extension.yml | Remove git URL formatting workflow. |
| .github/workflows/deptry.yml | Remove standalone deptry workflow. |
| wiki/Using-Workflow.md | Remove wiki documentation page. |
| wiki/Stages.md | Remove wiki documentation page. |
| wiki/Realisations.md | Remove wiki documentation page. |
| wiki/Realisation-Proposal.md | Remove wiki documentation page. |
| wiki/Home.md | Remove wiki landing page. |
| wiki/EMOD3D.md | Remove wiki documentation page. |
| wiki/Custom-Workflows.md | Remove wiki documentation page. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
claudio525
approved these changes
Sep 1, 2026
AndrewRidden-Harper
added a commit
that referenced
this pull request
Sep 2, 2026
Conflict in workflow/scripts/nshm2022_to_realisation.py: "Update CI (#135)" independently adapted the most_likely_fault call to nshmdb 2026.8.3's new leading fault_system argument by hardcoding nshmdb.FaultSystem.Crustal, while this branch threads the value through from the new --fault-system option. Kept pegasus's multi-line call layout (and the ty ignore on the magnitudes argument, still needed since most_likely_fault declares dict[str, float]) with fault_system in place of the hardcoded literal. Everything else merged cleanly: pegasus's dict(faults) invariance casts and this branch's db.connect()/fault_system lookups sit in disjoint hunks, and uv.lock's textual merge is consistent (uv lock --check passes). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019GHytYmpgE1CqWVKbzYWKe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.