refactor(cli): isolate platform internals#106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseintocmd/internal/platformand remove top-levelbase,ux, andansipackages.pkg/uiand keep product-facing contracts inpkg/cli/pkg/ui.products/production code unchanged while tighteninghack/check-productand runtime guard tests against legacy imports.api --repeatsfailure handling so failures include error detail and return a non-zero exit code.Validation
go test ./...go vet ./...make buildgo run ./hack/gen-productsgo test ./hack/snapshot -count=1go test ./hack/check-product -count=1go run ./hack/check-productgit diff --exit-code -- productstest ! -d base && test ! -d ux && test ! -d ansirg 'github.com/ucloud/ucloud-cli/(base|ux|ansi)' --glob '!docs/**' --glob '!TODOS.md'returned no matchesrg 'github.com/ucloud/ucloud-cli/(base|ux|ansi|cmd/internal)' products --glob '!**/*_test.go'returned no matchesE2E already verified on this branch
project listpassed.auth login --no-browserlocalhost callback flow passed.api --repeatsULHost create with invalid params returnedrc=1, printed API error detail, and follow-upDescribeULHostInstancereturnedTotalCount=0.Notes
products/code is intentionally unchanged.--profile=.../-p ...early-parse inconsistency is intentionally deferred and not part of this PR.