This repository was archived by the owner on May 1, 2023. It is now read-only.
Clean up LogicalReplicationListener#45
Merged
Merged
Conversation
cjfinnell
requested review from
SudKul and
cornerkitten
and removed request for
a team and
SudKul
January 10, 2022 21:47
bernielomax
approved these changes
Jan 11, 2022
| continue | ||
| } | ||
|
|
||
| if msg.WalMessage != nil { |
There was a problem hiding this comment.
Should this log/continue also? When are wal messages nil?
Author
There was a problem hiding this comment.
a msg from the db could include either/neither/both WalMessage and ServerHeartbeat - the previous codepath ignored the possible ServerHeartbeat if it found a WalMessage first
bernielomax
approved these changes
Jan 13, 2022
| } else { | ||
| l.logger.Warnf("received WAL with LSN %v, which is less than the current LSN %v", lsn, l.replLSN) | ||
| if lsn <= l.replLSN { | ||
| l.logger.Errorf("received WAL with LSN %v, which is not greater than last received LSN %v", lsn, l.replLSN) |
There was a problem hiding this comment.
Nit: The message formatter could be more dry but not essential.
This stored info is not used yet, but we will be using it to confirm if the target DB is in-sync with the source.
cjfinnell
force-pushed
the
cjfinnell/lr-nits
branch
from
January 14, 2022 16:08
651d603 to
a5dc720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of the changes contained in #37 and is intended to be a more focused/digestible/reviewable change.