Skip to content
This repository was archived by the owner on May 1, 2023. It is now read-only.

chore: go1.15 --> go1.17#49

Merged
cjfinnell merged 1 commit into
masterfrom
cjfinnell/go17
Jan 12, 2022
Merged

chore: go1.15 --> go1.17#49
cjfinnell merged 1 commit into
masterfrom
cjfinnell/go17

Conversation

@cjfinnell

Copy link
Copy Markdown

Test output:

$ make test integration-test 2>&1 | grep "\-\-\-"
--- PASS: TestAxonConfigListenerMode (0.00s)
    --- PASS: TestAxonConfigListenerMode/default_(notify) (0.00s)
    --- PASS: TestAxonConfigListenerMode/specify_notify (0.00s)
    --- PASS: TestAxonConfigListenerMode/specify_replication (0.00s)
    --- PASS: TestAxonConfigListenerMode/bad_mode (0.00s)
--- PASS: TestParseSemver (0.00s)
    --- PASS: TestParseSemver/9.5 (0.00s)
    --- PASS: TestParseSemver/9.5___(And_some_other_stuff... (0.00s)
    --- PASS: TestParseSemver/9.5.1__(patch_version_ignored) (0.00s)
    --- PASS: TestParseSemver/12.34__(multi-digit_check) (0.00s)
--- PASS: TestPipeline (0.30s)
--- PASS: TestNewConfigFromEnv (0.00s)
    --- PASS: TestNewConfigFromEnv/test_with_namespace (0.00s)
    --- PASS: TestNewConfigFromEnv/test_with_no_namespace (0.00s)
    --- PASS: TestNewConfigFromEnv/test_parse_database_config (0.00s)
--- PASS: TestParseLogLevel (0.00s)
--- PASS: TestVersionMigration (38.47s)
    --- PASS: TestVersionMigration/9.5To9.6 (19.00s)
    --- PASS: TestVersionMigration/custom11To11 (19.46s)

@bernielomax bernielomax left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should upgrade Dockerfiles, etc. Looks like they are out of sync which is why search/replace would not have worked. See - https://github.com/udacity/warp-pipe/blob/master/build/warp-pipe/Dockerfile

@cjfinnell

Copy link
Copy Markdown
Author

@bernielomax added dockerfile edits in the force-push

@cjfinnell
cjfinnell requested a review from bernielomax January 12, 2022 17:31

@bernielomax bernielomax left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@cjfinnell
cjfinnell merged commit de8ca67 into master Jan 12, 2022
@cjfinnell
cjfinnell deleted the cjfinnell/go17 branch January 12, 2022 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants