Fix ORM invalid ID lookups - #308
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 67cf078 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixes ➖ N/A
🟢 95-100% confidence
db.getdecode errorbun check✅ Outcome
null; many-through relations omit invalid targets; filtered through counts ignore them.kitcn/ormbehavior.convex-testmasks the production raw-ID rejection, so the regression boundary explicitly models production while existing real-Convex valid-ID tests remain in the focused run.lucide-reactfixture drift; generated snapshots were refreshed throughfixtures:sync.🏗️ Design
_getByIdowner used by all four affected direct reads.db.get, vector-provider hits, and the public API contract are outside this bug.🧪 Verified
bun vitest packages/kitcn/src/orm/query-invalid-id.vitest.ts packages/kitcn/src/orm/mutation-id-fast-path.vitest.ts --runbun --cwd packages/kitcn typecheckbun --cwd packages/kitcn buildbun lint:fixbun check