-
Notifications
You must be signed in to change notification settings - Fork 939
Table attributes disappear during copying #3549 #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table attributes disappear during copying #3549 #3550
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: f83f192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
12joan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleg-orlov-quantori Thanks for the PR.
We realised that the ability to set arbitrary DOM attributes on elements via the attributes property constitutes a security vulnerability, and we've disabled this feature by default on the latest version of Plate. See the security advistory for more information: GHSA-73rg-f94j-xvhx
Can you edit this PR so that withSetFragmentDataTable respects the node.dangerouslyAllowAttributes configuration option on the table plugin? If dangerouslyAllowAttributes is empty (which is the default case), the attributes property should be ignored.
|
|
|
@zbeyens Fixed. |
|
Thanks @oleg-orlov-quantori, you need to run |
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changesetFix for this issue #3549