fix(block-context-menu): prevent menu position sticking when triggered multiple times#4609
Merged
zbeyens merged 6 commits intoudecode:mainfrom Sep 8, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
zbeyens
requested changes
Sep 8, 2025
templates/plate-playground-template/src/components/ui/block-context-menu.tsx
Outdated
Show resolved
Hide resolved
…ntext-menu.tsx Co-authored-by: Ziad Beyens <ziad.beyens@gmail.com>
Co-authored-by: Ziad Beyens <ziad.beyens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4608
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changesetProblem
When users right-click to trigger the block context menu multiple times in different locations, the menu position gets stuck at the first trigger location instead of updating to the new click position. This affects both:
Root Cause
The
ContextMenuContentwas being rendered immediately without proper state management, causing the menu to render at the initial position and not re-render when the position changes.Solution
usePluginOptionto track menu open stateContextMenuContentwith conditional rendering based onisOpenstatesetTimeoutto ensure proper timing for menu positioningChanges
Files Modified
apps/www/src/registry/ui/block-context-menu.tsxtemplates/plate-playground-template/src/components/ui/block-context-menu.tsx