Skip to content

fix(www): render url videos in media node#4912

Merged
zbeyens merged 9 commits intomainfrom
codex/4625-video-url-render
Mar 28, 2026
Merged

fix(www): render url videos in media node#4912
zbeyens merged 9 commits intomainfrom
codex/4625-video-url-render

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented Mar 28, 2026

Summary

Fixes #4625 by restoring the live video renderer used by the docs and registry examples for videos inserted via URL. That insert path creates a video node with a url but no isUpload flag, and the live component only rendered YouTube embeds or uploaded files, so plain video URLs disappeared.

This falls back to ReactPlayer for non-YouTube video URLs, adds a regression spec for the plain URL case, and syncs the playground template plus generated registry output.

Testing

  • bun test apps/www/src/registry/ui/media-video-node.spec.tsx
  • pnpm --filter www build:registry
  • pnpm --filter www typecheck
  • pnpm lint:fix
  • pnpm check

@zbeyens zbeyens requested a review from a team March 28, 2026 07:27
@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Mar 28, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 28, 2026

⚠️ No Changeset found

Latest commit: 9c7eda7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plate Ready Ready Preview, Comment Mar 28, 2026 0:15am

Request Review

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. patch Bugfix & documentation PR plugin:media regression labels Mar 28, 2026
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 28, 2026
@zbeyens zbeyens merged commit c395f4b into main Mar 28, 2026
7 checks passed
@zbeyens zbeyens deleted the codex/4625-video-url-render branch March 28, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Bugfix & documentation PR plugin:media regression size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video:It is not render, when I add a video from “Insert Via URL ”

1 participant