fix(www): render url videos in media node#4912
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4625 by restoring the live video renderer used by the docs and registry examples for videos inserted via URL. That insert path creates a
videonode with aurlbut noisUploadflag, and the live component only rendered YouTube embeds or uploaded files, so plain video URLs disappeared.This falls back to
ReactPlayerfor non-YouTube video URLs, adds a regression spec for the plain URL case, and syncs the playground template plus generated registry output.Testing
bun test apps/www/src/registry/ui/media-video-node.spec.tsxpnpm --filter www build:registrypnpm --filter www typecheckpnpm lint:fixpnpm check