fix(table): avoid arrow caret flash#4923
Merged
zbeyens merged 2 commits intoudecode:mainfrom Mar 29, 2026
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 42eeb13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Awesome, we were blocked on this one before Codex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plain
ArrowUp/ArrowDownnavigation in table cells could briefly flash the native caret before the selection moved to the adjacent cell.Issue:
Screen.Recording.2026-03-29.at.21.00.54.mov
Previous flow:
overrideSelectionFromCellwatched for the browser selection updatemoveSelectionFromCellin asetTimeoutUpdated flow:
withTable.moveLinemoveSelectionFromCellmoves selection to the adjacent cellBehavior covered by the new path:
What stays the same:
overrideSelectionFromCellstill handles shift-based table selection expansionmoveSelectionFromCellremains the transform that performs the actual cross-cell moveTesting
pnpm install --ignore-scriptspnpm turbo build --filter=./packages/tablepnpm turbo typecheck --filter=./packages/tablepnpm lint:fixbun test packages/table/src/libChecklist
pnpm typecheckpnpm lint:fixbun testpnpm brlpnpm changeset