[codex] Fix discussion and suggestion regressions#4945
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 59e0883 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Keep inline-void deletion atomic, reuse suggestion ids across inline boundaries, move link coverage to real app integration tests, and patch the deleteSuggestion test harness so check stays green.
Keep expanded selection delete and replace flows progressing across mention-shaped inline voids, add regressions for delete and insertText, and carry the generated next-env route typing update already present in the worktree.
Checkpoint the current no-package-use-client experiments across app registry and React surface imports before the next round of build debugging.
dosubot
Bot
added
size:M
|
@codex review - instead of suggestion-node import in most blocks, would you have a dependency-free @/lib/ import as we do for transforms? and which registry deps are missing? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50f4c1c557
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Move the shared inline suggestion class into a dependency-free registry lib, inject static inline suggestion data from the base kit, and drop the old static helper path.
|
@codex review again about registry deps |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Support inline suggestion classes on nodes that carry the injected data attribute themselves, and lock that shape in with direct-token regression checks for mention and link.
dosubot
Bot
added
size:XXL
felixfeng33
force-pushed
the
codex/simplify-discussion-ui
branch
from
091fc86 to
59e0883
Compare
2 participants
Summary
This PR simplifies discussion UI plumbing and fixes a batch of suggestion regressions across block and inline editing flows.
What changed
Add: Paragraphsuggestionsapps/www/src/__tests__/package-integrationand documented the new suggestion edge cases indocs/solutions/Validation
pnpm check