Skip to content

fix(ci): run dependency probe apt step as root - #75

Merged
fqjony merged 1 commit into
latestfrom
fix/dependency-probe-root-user
Jul 30, 2026
Merged

fix(ci): run dependency probe apt step as root#75
fqjony merged 1 commit into
latestfrom
fix/dependency-probe-root-user

Conversation

@fqjony

@fqjony fqjony commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The problem

https://github.com/udx/worker-nodejs/actions/runs/30517941072/job/90791862424

image

Summary

  • Run the generated dependency probe package-install layer as root.
  • Restore the image runtime user before probing installed package versions.

Validation

  • Ruby YAML parse
  • git diff --check

Copilot AI review requested due to automatic review settings July 30, 2026 08:49
@fqjony
fqjony requested a review from a team July 30, 2026 08:50
@fqjony fqjony self-assigned this Jul 30, 2026
@fqjony fqjony added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Jul 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Docker dependency updater workflow so the generated “dependency probe” Dockerfile can successfully install apt packages even when the base image defaults to a non-root user, while preserving the intended runtime user for the version-probing step.

Changes:

  • Insert USER root into the generated probe Dockerfile before the apt install layer.
  • Restore the original image user via USER "${USER}" after the apt install layer so docker run probes under the expected runtime user.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fqjony
fqjony enabled auto-merge July 30, 2026 08:51
@fqjony
fqjony merged commit 9232708 into latest Jul 30, 2026
9 checks passed
@fqjony
fqjony deleted the fix/dependency-probe-root-user branch July 30, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants