Merged
Conversation
Apparently kernel.src cannot be directly assigned in v3, so store src in a local copy and modify that one before applying the updates. Tested on simulated streaming audio locally. see openai/whisper#2597
The previous commit added Triton 3.x support but broke backward compatibility with Triton 2.x by requiring triton>=3.0.0. This commit restores compatibility with both versions by following the upstream OpenAI Whisper approach: - Use hasattr() to detect which API is available - Call _unsafe_update_src() + hash reset for Triton 3.0-3.1 - Fall back to kernel.src for Triton 2.x - Restore triton>=2.0.0 requirement (supports both 2.x and 3.x) This matches the implementation in openai/whisper and addresses the maintainer feedback to follow upstream more closely. Builds on: ufal#22 See: openai/whisper#2597
Contributor
|
@krystophny thanks for posting this, mine is more of a hack for Debian 13, your PR should probably be accepted over mine. |
|
Why hasn't this pull request been merged? |
Member
|
hi,
because I couldn't reproduce it and couldn't test it.
And I didn't have time. And third, this is an issue in the original
openai-whisper. We should copy their exact code, this seemed different.
But ok. Simce you confirm it works, I'll check if it still works on my HW
and OS and I'll merge it.
Fumin ***@***.***> schrieb am Di. 27. 1. 2026 um 07:11:
… *fumin* left a comment (ufal/SimulStreaming#23)
<#23 (comment)>
Why hasn't this pull request been merged?
This is the fix to #30 <#30>
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIRQXOOZVFJU7QQXWA573L4I4FT7AVCNFSM6AAAAACKLLCYN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBTGQ4TMOJTGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small addition to PR #22 since I have been changing this in parallel. In this variant, triton v2 is still working too, and Linux OS is correctly added again in requirements (whisper upstream has that too). If fine, please merge after #22 .