Skip to content

Select element types/dimension/order to be built via cmake#1092

Merged
chleh merged 1 commit intoufz:masterfrom
chleh:select-elements
Mar 14, 2016
Merged

Select element types/dimension/order to be built via cmake#1092
chleh merged 1 commit intoufz:masterfrom
chleh:select-elements

Conversation

@chleh
Copy link
Copy Markdown
Collaborator

@chleh chleh commented Mar 11, 2016

This PR adds the following cmake options, which enable selection of element types to be built via cmake. That possibly saves compile time. The effect will be more significant for fixed-size shape matrices, not so much for dynamically allocated ones.

OGS_ENABLE_ELEMENT_CUBOID
OGS_ENABLE_ELEMENT_PRISM
OGS_ENABLE_ELEMENT_PYRAMID
OGS_ENABLE_ELEMENT_SIMPLEX
OGS_MAX_ELEMENT_DIM
OGS_MAX_ELEMENT_ORDER

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Mar 11, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1411/

@chleh chleh force-pushed the select-elements branch from 4e66398 to 035e38c Compare March 11, 2016 15:30
@chleh
Copy link
Copy Markdown
Collaborator Author

chleh commented Mar 11, 2016

Fixed it.

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Mar 11, 2016

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/1390/

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Mar 11, 2016

Jenkins: OGS-6/Gui/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Mac-PRs/1281/

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Mar 11, 2016

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1279/

@chleh
Copy link
Copy Markdown
Collaborator Author

chleh commented Mar 11, 2016

At least for non-GUI. ^^

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Mar 11, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/1417/

@endJunction
Copy link
Copy Markdown
Member

endJunction commented Mar 11, 2016

Be aware that when for example only pyramids are enabled the triangles and quads should also be available because of the boundary. ✅

@chleh
Copy link
Copy Markdown
Collaborator Author

chleh commented Mar 11, 2016

Gonna rethink it.

@chleh chleh force-pushed the select-elements branch from e6a8288 to a21c63a Compare March 11, 2016 19:17
@wenqing
Copy link
Copy Markdown
Member

wenqing commented Mar 14, 2016

Also line element should be enabled by default because it is used as edge type to assign BCs for all types of element.

@chleh
Copy link
Copy Markdown
Collaborator Author

chleh commented Mar 14, 2016

The macro ENABLED_ELEMENT_TYPE_LINE should make sure that lines and points are effectively always enabled.

@chleh
Copy link
Copy Markdown
Collaborator Author

chleh commented Mar 14, 2016

Note: Just added an error message for nonexistent mesh element types. 50269d1

endJunction
endJunction reviewed Mar 14, 2016
View reviewed changes
Comment thread scripts/cmake/OGSEnabledElements.cmake Outdated
@@ -0,0 +1,24 @@
# Definitions controlling which FEM elements will be compiled
if(NOT OGS_MAX_ELEMENT_DIM MATCHES "^[0-9]$")
Copy link
Copy Markdown
Member

@endJunction endJunction Mar 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0-3 is sufficient. ✅

@endJunction
Copy link
Copy Markdown
Member

endJunction commented Mar 14, 2016

⏩ from my side.

@wenqing
Copy link
Copy Markdown
Member

wenqing commented Mar 14, 2016

👍

@chleh chleh force-pushed the select-elements branch from 50269d1 to 6751201 Compare March 14, 2016 17:06
chleh added a commit that referenced this pull request Mar 14, 2016
@chleh
Merge pull request #1092 from chleh/select-elements
48dd5f7 
Select element types/dimension/order to be built via cmake
@chleh chleh merged commit 48dd5f7 into ufz:master Mar 14, 2016
@chleh chleh deleted the select-elements branch March 14, 2016 17:09
@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chleh @ogsbot @endJunction @wenqing