Remove mesh lib on file io dependency#1153
Merged
endJunction merged 2 commits intoufz:masterfrom Apr 21, 2016
endJunction:RemoveMeshLibOnFileIODependency
Merged
Remove mesh lib on file io dependency#1153endJunction merged 2 commits intoufz:masterfrom endJunction:RemoveMeshLibOnFileIODependency
endJunction merged 2 commits intoufz:masterfrom
endJunction:RemoveMeshLibOnFileIODependency
Conversation
| { | ||
| OGSError::box(QString::fromStdString( | ||
| "Error mapping mesh. Could not read raster file " + | ||
| dlg.getRasterPath())); |
Member
There was a problem hiding this comment.
This is a nice side effect: A possible error message can be displayed directly in the DataExplorer.
Member
|
⏩ |
Collaborator
|
⏩ |
Member
Author
|
For uptodate relations see Doxygen, e.g. for MeshLib where there is MeshLib<->FileIO dependency, but will be "FileIO depends on MeshLib only" after this is merged. |
Use instead layered mesh constructor taking a GeoLib::Raster. Reading of the raster happens inside the application now.
Member
|
OpenGeoSys development has been moved to GitLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow this dependency slipped past my mind.
Moving reading of the file into DE.
Use instead layered mesh constructor taking a GeoLib::Raster.
Reading of the raster happens inside the application now.
Typo was "wher". No changes to the comment otherwise.