remove #ifdef OGS_USE_EIGEN from local matrix related files#1218
Merged
endJunction merged 1 commit intoufz:masterfrom May 27, 2016
Merged
remove #ifdef OGS_USE_EIGEN from local matrix related files#1218endJunction merged 1 commit intoufz:masterfrom
endJunction merged 1 commit intoufz:masterfrom
Conversation
norihiro-w
force-pushed
the
remove_USE_EIGEN
branch
from
16bd937 to
a776796
Compare
|
|
||
| add_definitions(-DEIGEN_INITIALIZE_MATRICES_BY_ZERO) # TODO check if needed | ||
| if (EIGEN_NO_DEBUG) | ||
| add_definitions(-DEIGEN_NO_DEBUG) |
Collaborator
There was a problem hiding this comment.
Shall we really keep that? AFAIK it disables Eigen checks even in debug mode.
Collaborator
Author
There was a problem hiding this comment.
I would keep it as it can speed up debugging when you are sure that Eigen related parts are fine and there will be a bug in other places. Note that EIGEN_NO_DEBUG is OFF by default.
Collaborator
|
👍 |
Member
|
OpenGeoSys development has been moved to GitLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as titled. #ifdef OGS_USE_EIGEN is still used for global matrix, vector, and linear solver.