Merged
Conversation
Member
|
Jenkins: OGS-6/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Win-PRs/2011/ |
| void StationTreeModel::setNameForItem(const std::string &stn_vec_name, std::size_t id, std::string item_name) | ||
| { | ||
| auto const stn_list = find_if(_lists.begin(), _lists.end(), [&stn_vec_name](ModelTreeItem* item) | ||
| { return (stn_vec_name.compare( item->data(0).toString().toStdString() ) == 0); }); |
Collaborator
There was a problem hiding this comment.
Minor: You can compare for equality using ==.
Collaborator
|
after questions answered 👍 |
Member
|
Looks OK. Const correctness can be improved. |
rinkk
force-pushed
the
ModifyStationNames
branch
from
c3f39da to
c4034e7
Compare
Member
|
Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/2019/ |
rinkk
force-pushed
the
ModifyStationNames
branch
from
7c9b316 to
e622007
Compare
Member
|
Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2187/ |
Member
|
Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/411/ |
Member
|
OpenGeoSys development has been moved to GitLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...as requested for the GW tutorial book.