Merged
Conversation
1 task
chleh
force-pushed
the
named-functions
branch
3 times, most recently
from
9820f66 to
e910f65
Compare
| template <typename ReturnType, typename... Arguments> | ||
| NamedFunction( | ||
| std::string const& name, | ||
| std::vector<ArgumentInfo>&& arguments, |
Collaborator
There was a problem hiding this comment.
better to name it argument_names ✅
Collaborator
|
i checked only class interface. Comments are mostly about naming of functions etc. |
Collaborator
Author
|
I'll do the renaming when the main part of the code review has been finished. |
| generateCaller<21>(), generateCaller<22>(), generateCaller<23>(), | ||
| generateCaller<24>(), generateCaller<25>(), generateCaller<26>(), | ||
| generateCaller<27>(), generateCaller<28>(), generateCaller<29>(), | ||
| generateCaller<30>(), generateCaller<31>()}; |
Collaborator
Author
There was a problem hiding this comment.
TODO: MAX_FUNCTION_ARGS is 32. ✅
Collaborator
|
i will not review cpp files because there are many things I don't understand and these code will be used only for output. If the renaming is done, this PR is ok from my side. |
| return; | ||
|
|
||
| auto const& si_so = map_sink_source[sink_fct]; | ||
| int const num_args = si_so.size(); |
Member
There was a problem hiding this comment.
auto or std::size_t (resolves some of the implicit conversions...) ✅
|
|
||
| enum class TraversePosition { StartNode, BetweenChildren, EndNode }; | ||
|
|
||
| template <typename Callback> |
Mainly clarifying the algorithm and micro-optimiziations.
Member
|
OpenGeoSys development has been moved to GitLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #1312.
This PR adds classes that enable the construction of expression trees dynamically at runtime.
That roughly goes into the direction discussed recently in the frame of constitutive relations.
However, I want to use the code provided here at first to compute secondary variables.
For a usage example, please have a look at the tests. There will be a follow-up PR coupling this PR with FEM processes, soon.