Heat transport process added by grubbymoon · Pull Request #1328 · ufz/ogs

grubbymoon · 2016-07-25T16:24:21Z

validated with 1D heat conduction analytical solution with dirichlet boundary

ogsbot · 2016-08-01T16:02:38Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2442/

endJunction · 2016-08-01T20:10:03Z

 endif()
 if(TARGET Boost)
-    add_dependencies(ProcessLib Boost)
+	add_dependencies(ProcessLib Boost)


If possible, please keep the original formatting of the lines you don't change.

Thanks, corrected

endJunction · 2016-08-01T20:32:50Z

I would not call this process a "heat transport" process, which, for me, implies non-linear advective transport; better to call it "linear heat diffusion", or "linear heat equation", or "conductive heat transfer", or "heat conduction".

wenqing · 2016-08-02T08:15:06Z

+        temperature_analytical.vtu line_60_heat_pcs_0_ts_81_t_31640625.000000.vtu Temperature_Analytical_1year temperature
+   )
+
+AddTest(


Indentations in this AddTest needs four spaces.

ogsbot · 2016-08-02T09:32:48Z

Jenkins: OGS-6/Mac-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Mac-PRs/2310/

ogsbot · 2016-08-02T09:33:47Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/668/

ogsbot · 2016-08-02T09:33:49Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2445/

ogsbot · 2016-08-02T09:34:29Z

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/2392/

chleh · 2016-08-02T09:45:17Z

Jenkins, test this please.

ogsbot · 2016-08-02T09:56:25Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2446/

ogsbot · 2016-08-02T09:58:06Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/669/

ogsbot · 2016-08-02T12:32:46Z

Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/2394/

wenqing · 2016-08-02T12:43:19Z

@endJunction As for the name of process, I think HEAT_TRANSPORT is adequate because that we only need one object to handle the simulation of heat transport process, the PDE of which could be linear or non-linear, or which is coupled to other physical processes. The advection term, which is a coupling term to fluid process, is not calculated in this PR so far.

wenqing · 2016-08-02T12:47:29Z

@endJunction The advection term could be added in future in the implementation of coupled TH process.

endJunction · 2016-08-02T22:31:57Z

+        EXECUTABLE_ARGS line_60_heat.prj
+        WRAPPER time
+        TESTER vtkdiff
+        ABSTOL 1e-2 RELTOL 1e-2


I'd say that in absence of any singularities in the solution, the tolerances are a little to sloppy. Why is it so? Can we improve it?

i have improved the tolerances from 1e-2 to 1e-4. The error between analytical solution and numerical solution is normally a little bit sloppy compared with the error between two numerical solutions

ogsbot · 2016-08-04T10:24:01Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/685/

grubbymoon · 2016-09-01T15:40:44Z

@endJunction @wenqing @chleh Please review again !

chleh · 2016-09-01T15:55:26Z

@@ -0,0 +1,380 @@
+/**


This file an artefact of your rebasing. Please remove it.
And please also remove the file .merge_file_R8GkSe

removed them.

ogsbot · 2016-09-01T16:01:13Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2781/

chleh · 2016-09-01T16:01:36Z

+{
+class HeatConductionProcess final : public Process
+{
+    using Base = Process;


This line is probably unneeded. Please remove it.

chleh · 2016-09-01T16:09:58Z

Only small things from my side. Afterwards and after data cleanup 👍

ogsbot · 2016-09-01T16:41:06Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2782/

endJunction · 2016-09-02T13:21:45Z

+            _localM.noalias() += sm.N.transpose() * density * heat_capacity *
+                                 sm.N * sm.detJ * wp.getWeight();
+            // heat flux only computed for output.
+            const NodalVectorType heat_flux =


Needs checking of the correct size. And remove extra parentheses.

@endJunction I have tested the error threshold. 1e-4 is required for neumann boundary and 1e-5 is fine with dirichlet boundary ! I have updated the threshold.

Add heat conduction process.

endJunction · 2016-09-04T21:53:40Z

Merged in master

Had to update Tests/Data due to unrelated files. Also squashed the fixes for clarity.

ogsbot · 2020-06-19T12:32:47Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

grubbymoon added the WIP 🏗️ label Jul 25, 2016

grubbymoon force-pushed the HeatTransport_Pull branch 2 times, most recently from cd2b89c to 053c3c1 Compare August 1, 2016 15:53

grubbymoon added please review and removed WIP 🏗️ labels Aug 1, 2016

endJunction reviewed Aug 1, 2016
View reviewed changes

wenqing reviewed Aug 2, 2016
View reviewed changes

grubbymoon force-pushed the HeatTransport_Pull branch from 8496c10 to 699d450 Compare August 2, 2016 18:03

endJunction reviewed Aug 2, 2016
View reviewed changes

grubbymoon added 5 commits September 1, 2016 12:13

commit before rebasing

e299081

after rebasing fix all the compiling errors

a6169d9

reduce the timestep in test case to get a smoother result

c14a6b5

after running clang-format

5e9731f

fix compile errors after rebasing

20b7161

grubbymoon force-pushed the HeatTransport_Pull branch from 4f1f443 to 20b7161 Compare September 1, 2016 15:36

chleh reviewed Sep 1, 2016
View reviewed changes

add Data

7b9b2d0

grubbymoon added 5 commits September 1, 2016 22:27

add Tests/Data

736b011

delete unused file

5710f28

fix the trailing white spapce

84f23e5

delete unused files

d9ce9ec

shrink the comments into one line

373be76

endJunction reviewed Sep 2, 2016
View reviewed changes

grubbymoon added 2 commits September 2, 2016 15:50

fixed some minor errors and change the tolerance

561b2ba

update Tests/Data

fbe6e7f

endJunction removed the please review label Sep 4, 2016

endJunction added a commit that referenced this pull request Sep 4, 2016

Merge pull request #1328 from grubbymoon/HeatTransport_Pull

c3308e2

Add heat conduction process.

endJunction closed this Sep 4, 2016

Conversation

grubbymoon commented Jul 25, 2016

Uh oh!

ogsbot commented Aug 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

endJunction commented Aug 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

chleh commented Aug 2, 2016

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

ogsbot commented Aug 2, 2016

Uh oh!

wenqing commented Aug 2, 2016

Uh oh!

wenqing commented Aug 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ogsbot commented Aug 4, 2016

Uh oh!

grubbymoon commented Sep 1, 2016

Uh oh!

chleh Sep 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ogsbot commented Sep 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chleh commented Sep 1, 2016

Uh oh!

ogsbot commented Sep 1, 2016

Uh oh!

endJunction Sep 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

endJunction commented Sep 4, 2016

Uh oh!

ogsbot commented Jun 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chleh Sep 1, 2016 •

edited

Loading

endJunction Sep 2, 2016 •

edited

Loading