[PL] Add multicomponent boundary conditions.#1343
Merged
endJunction merged 3 commits intoufz:masterfrom Aug 12, 2016
endJunction:MulticomponentBcs
Merged
[PL] Add multicomponent boundary conditions.#1343endJunction merged 3 commits intoufz:masterfrom endJunction:MulticomponentBcs
endJunction merged 3 commits intoufz:masterfrom
endJunction:MulticomponentBcs
Conversation
Collaborator
|
⏩ Regarding the default of zero: Then for multi-component-BCs one implicitly always sets BCs to component no. 0 if one forgets to explicitly specify it. |
Member
Author
|
I'm adding an extra check, which in case of missing for multi-component variables will issue the following message: |
| //! \ogs_file_param{boundary_condition__component} | ||
| bc_config.getConfigParameter<int>("component", 0); | ||
| if (_n_components > 1) { | ||
| bc_config.peekConfigParameter<int>("component"); |
Collaborator
There was a problem hiding this comment.
I thought peek after get doesn't work. At least I didn't want it to work in that order. ^^
The main work was done before, but the parser was missing.
Collaborator
|
👍 |
Member
|
OpenGeoSys development has been moved to GitLab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main work was done before, but the parser was missing.
The default value for the component is 0 such that there is no need to add for single component variables.
TODO: