Skip to content

support tetrahedra in generateStructuredMesh#1353

Merged
norihiro-w merged 4 commits intoufz:masterfrom
norihiro-w:meshgen-tet
Aug 25, 2016
Merged

support tetrahedra in generateStructuredMesh#1353
norihiro-w merged 4 commits intoufz:masterfrom
norihiro-w:meshgen-tet

Conversation

@norihiro-w
Copy link
Copy Markdown
Collaborator

@norihiro-w norihiro-w commented Aug 15, 2016 •
edited
Loading

This PR adds support of tetrahedral element type in generateStructuredMesh tool

endJunction
endJunction reviewed Aug 15, 2016
View reviewed changes
Comment thread MeshLib/MeshGenerators/MeshGenerator.h
const BaseLib::ISubdivision &div_y,
const BaseLib::ISubdivision &div_z,
MathLib::Point3d const& origin = MathLib::ORIGIN,
std::string const& mesh_name = "mesh");
Copy link
Copy Markdown
Member

@endJunction endJunction Aug 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mesh_name doxygen parameter doc missing... ✅

@norihiro-w
Copy link
Copy Markdown
Collaborator Author

norihiro-w commented Aug 15, 2016

The suggested code is not generating a correct mesh. Faces of adjacent tetrahedras don't match. I need some more time to fix the issue

@endJunction
Copy link
Copy Markdown
Member

endJunction commented Aug 15, 2016

After the coordinates are corrected, ⏩ from my side...

@chleh
Copy link
Copy Markdown
Collaborator

chleh commented Aug 25, 2016

I believe you that you did the splitting right. Code is OK.
Maybe there could be a small comment like "This algorithm generates a structured hex-mesh and splits each hex into six tets."
👍

@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Aug 25, 2016

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2700/

@norihiro-w
Copy link
Copy Markdown
Collaborator Author

norihiro-w commented Aug 25, 2016

Jenkins error is nothing to do with this PR. The error is in NumLib.ComponentNormMultiComponent2

@norihiro-w
Copy link
Copy Markdown
Collaborator Author

norihiro-w commented Aug 25, 2016

travis error is nothing do with this PR. the error is in NumLib.ComponentNormSingleComponent.

@chleh
Copy link
Copy Markdown
Collaborator

chleh commented Aug 25, 2016

Then please rebase and merge.

@TomFischer
Copy link
Copy Markdown
Member

TomFischer commented Aug 25, 2016

Could you please also update the documentation on the website: https://docs.opengeosys.org/docs/tools/meshing/structured-mesh-generation?

@norihiro-w
Copy link
Copy Markdown
Collaborator Author

norihiro-w commented Aug 25, 2016

@TomFischer how can I modify the doc?

@endJunction
Copy link
Copy Markdown
Member

endJunction commented Aug 25, 2016

Never mind the docs. page for now, something is wrong with the logins...

@endJunction
Copy link
Copy Markdown
Member

endJunction commented Aug 25, 2016

Jenkins, test this please!

@norihiro-w norihiro-w merged commit cc4b9cc into ufz:master Aug 25, 2016
@norihiro-w norihiro-w deleted the meshgen-tet branch August 25, 2016 20:35
@ogsbot
Copy link
Copy Markdown
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@norihiro-w @endJunction @chleh @ogsbot @TomFischer