Mechanics invariants and B-matrices#1359
Mechanics invariants and B-matrices#1359endJunction merged 6 commits intoufz:masterfrom endJunction:MechanicsInvariantsBMatrices
Conversation
| { | ||
| Eigen::Matrix<double, 1, 1> m; | ||
| m << v[0]; | ||
| m.coeffRef(0,0) = v[0]; |
There was a problem hiding this comment.
maybe m(0,0) = v[0], or something like Eigen::Matrix<double, 1, 1> m = Eigen::Matrix<double, 1, 1>::Constant(v[0])?
|
Jenkins, test this please. The following ctests FAILED for some reason but they don't affect the review for now: |
| struct KelvinVectorDimensions; | ||
|
|
||
| template <> | ||
| struct KelvinVectorDimensions<1> |
There was a problem hiding this comment.
Can that be removed now? ✅
|
Only minor additional comments from my side. Basically:
Afterwards 👍 |
| Eigen::Matrix<double, KelvinVectorSize, KelvinVectorSize> P_dev = | ||
| Eigen::Matrix<double, KelvinVectorSize, KelvinVectorSize>::Identity(); | ||
|
|
||
| P_dev.template topLeftCorner<3, 3>() -= |
There was a problem hiding this comment.
unsure: noalias() may influence optimization
|
looks good, besides minor comments |
|
Jenkins: OGS-6/Gui/Gui-Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Gui-Linux-PRs/2630/ |
|
Can I rebase and merge, or is there more review to be expected? The only test failing (again) is |
|
I'm fine with this PR. ⏩ |
|
Jenkins, test this please! |
|
It could happen that the error margins in the unit tests are too tight. In that case I'll increase the tolerance a little. |
|
OpenGeoSys development has been moved to GitLab. |
This is part of the mechanics PR #1340.
Includes:
For the tests the error bounds were eyeballed from a gnuplot graphics showing the error vs. input vector norm. Tried to make them as tight as possible. It might happen that they will need to be increased a little bit... we'll see.
Aside from the failing compiler (of the test code) this is ready for review.
Todo: