Skip to content

Add Astropy units support - #49

Merged
dprada merged 3 commits into
mainfrom
codex/add-astropy-module-support-with-tests
Sep 26, 2025
Merged

Add Astropy units support#49
dprada merged 3 commits into
mainfrom
codex/add-astropy-module-support-with-tests

Conversation

@dprada

@dprada dprada commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

Summary

  • add an astropy.units form implementation with conversions, dimensionality, and parser support
  • register the Astropy form across configuration, parser dispatch, and string translation helpers
  • cover the new form with Astropy-focused tests and update configuration expectations

Testing

  • pytest

https://chatgpt.com/codex/tasks/task_e_68d5c8acfc4c8326b42a74f902bee1d0

@codecov

codecov Bot commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.57%. Comparing base (8f57a8f) to head (0345616).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread pyunitwizard/forms/api_astropy_unit.py
@dprada
dprada requested a review from Copilot September 26, 2025 00:56
@dprada dprada self-assigned this Sep 26, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Astropy units to pyunitwizard by implementing a new form that handles conversions, dimensionality, and parsing for Astropy units. The implementation includes registration across the configuration system and comprehensive test coverage.

  • Adds new Astropy units form implementation with conversion and dimensionality support
  • Registers Astropy form in configuration, parser dispatch, and string translation systems
  • Includes comprehensive test coverage for the new functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pyunitwizard/forms/api_astropy_unit.py Outdated
Comment thread pyunitwizard/forms/api_astropy_unit.py Outdated
Comment thread pyunitwizard/forms/api_astropy_unit.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dprada
dprada requested a review from Copilot September 26, 2025 01:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dprada
dprada merged commit d3f02a1 into main Sep 26, 2025
7 checks passed
@dprada
dprada deleted the codex/add-astropy-module-support-with-tests branch September 26, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants