Move water use data structure to a dataclass#4120
Merged
timothy-nunn merged 4 commits intomainfrom Mar 25, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4120 +/- ##
==========================================
+ Coverage 47.30% 47.64% +0.34%
==========================================
Files 140 143 +3
Lines 29448 29986 +538
==========================================
+ Hits 13929 14286 +357
- Misses 15519 15700 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aclass data structure
je-cook
reviewed
Mar 24, 2026
Collaborator
je-cook
left a comment
There was a problem hiding this comment.
I think this looks good as a half way house (excluding the known shittyness). A couple of comments on the tests
je-cook
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
water_use_variables.pyglobal variables into a dataclass and provides the infrastructure for managing this new way of managing data.