Skip to content

Move water use data structure to a dataclass#4120

Merged
timothy-nunn merged 4 commits intomainfrom
wateruse-dataclass
Mar 25, 2026
Merged

Move water use data structure to a dataclass#4120
timothy-nunn merged 4 commits intomainfrom
wateruse-dataclass

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Moves the water_use_variables.py global variables into a dataclass and provides the infrastructure for managing this new way of managing data.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 87.35632% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.64%. Comparing base (0f65c5e) to head (dd6d4b2).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
process/main.py 57.14% 6 Missing ⚠️
process/core/io/data_structure_dicts.py 0.00% 2 Missing ⚠️
process/core/caller.py 0.00% 1 Missing ⚠️
process/core/output.py 0.00% 1 Missing ⚠️
process/models/water_use.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4120      +/-   ##
==========================================
+ Coverage   47.30%   47.64%   +0.34%     
==========================================
  Files         140      143       +3     
  Lines       29448    29986     +538     
==========================================
+ Hits        13929    14286     +357     
- Misses      15519    15700     +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as ready for review March 5, 2026 16:28
@timothy-nunn timothy-nunn requested a review from a team as a code owner March 5, 2026 16:28
@je-cook je-cook added the Data structure Issues related to the data structure label Mar 24, 2026
Copy link
Copy Markdown
Collaborator

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good as a half way house (excluding the known shittyness). A couple of comments on the tests

@timothy-nunn timothy-nunn requested a review from je-cook March 25, 2026 10:21
@timothy-nunn timothy-nunn merged commit 5f14026 into main Mar 25, 2026
10 checks passed
@timothy-nunn timothy-nunn deleted the wateruse-dataclass branch March 25, 2026 15:09
@clmould clmould mentioned this pull request Mar 25, 2026
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants