Skip to content

Support input's being set on new data structure dataclass#4154

Merged
je-cook merged 6 commits intomainfrom
new-data-structure-inputs
Apr 1, 2026
Merged

Support input's being set on new data structure dataclass#4154
je-cook merged 6 commits intomainfrom
new-data-structure-inputs

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

In #4120 I forgot to handle the setting of inputs inside this new data structure. At present, the inputs are being set as attributes on the Python module, which does nothing because the data is now inside of a dataclass.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.01%. Comparing base (771e4d2) to head (ea07fba).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
process/main.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4154      +/-   ##
==========================================
+ Coverage   47.81%   48.01%   +0.19%     
==========================================
  Files         143      143              
  Lines       29993    30164     +171     
==========================================
+ Hits        14342    14482     +140     
- Misses      15651    15682      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn added the Data structure Issues related to the data structure label Mar 31, 2026
@timothy-nunn timothy-nunn marked this pull request as ready for review April 1, 2026 08:35
@timothy-nunn timothy-nunn requested a review from a team as a code owner April 1, 2026 08:35
@timothy-nunn timothy-nunn requested a review from je-cook April 1, 2026 13:14
@je-cook je-cook merged commit 893a36c into main Apr 1, 2026
10 checks passed
@je-cook je-cook deleted the new-data-structure-inputs branch April 1, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants