Add tf inside cs enum - #4362
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4362 +/- ##
=======================================
Coverage 48.79% 48.79%
=======================================
Files 151 151
Lines 29383 29408 +25
=======================================
+ Hits 14337 14351 +14
- Misses 15046 15057 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
requested changes
Jun 23, 2026
clmould
left a comment
Collaborator
There was a problem hiding this comment.
Just 1 thing but everything else good:
In test_tfcoil.py there are some instances of i_tf_inside_cs=0 - could these be updated to use the enum value instead please?
clmould
reviewed
Jun 23, 2026
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
chris-ashe
force-pushed
the
add_tf_inside_cs_enum
branch
from
June 23, 2026 12:35
27c2903 to
b8480fe
Compare
clmould
reviewed
Jun 23, 2026
clmould
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: