Tidy up data_structure_dicts.py - #4378
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4378 +/- ##
==========================================
+ Coverage 48.79% 48.86% +0.06%
==========================================
Files 151 151
Lines 29408 29351 -57
==========================================
- Hits 14351 14341 -10
+ Misses 15057 15010 -47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timothy-nunn
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Had to add a 2nd method of getting the DICT_DESCRIPTIONS in #4215 due to having a mix of old data structure files and new ones (with the dataclasses). Now that we only have dataclasses, the old method is no longer necessary so needs to be removed.
Also general tidying of the file, removing old, unused functions.
Checklist
I confirm that I have completed the following checks: