Skip to content

Tidy up data_structure_dicts.py - #4378

Merged
timothy-nunn merged 2 commits into
mainfrom
4333-clean-up-data_structure_dictspy
Jun 24, 2026
Merged

Tidy up data_structure_dicts.py#4378
timothy-nunn merged 2 commits into
mainfrom
4333-clean-up-data_structure_dictspy

Conversation

@clmould

@clmould clmould commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Description

Had to add a 2nd method of getting the DICT_DESCRIPTIONS in #4215 due to having a mix of old data structure files and new ones (with the dataclasses). Now that we only have dataclasses, the old method is no longer necessary so needs to be removed.
Also general tidying of the file, removing old, unused functions.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Jun 24, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.86%. Comparing base (3fe7140) to head (699a6ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4378      +/-   ##
==========================================
+ Coverage   48.79%   48.86%   +0.06%     
==========================================
  Files         151      151              
  Lines       29408    29351      -57     
==========================================
- Hits        14351    14341      -10     
+ Misses      15057    15010      -47     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould
clmould marked this pull request as ready for review June 24, 2026 10:27
@clmould
clmould requested a review from a team as a code owner June 24, 2026 10:27
@timothy-nunn
timothy-nunn merged commit a68bb7f into main Jun 24, 2026
10 of 11 checks passed
@timothy-nunn
timothy-nunn deleted the 4333-clean-up-data_structure_dictspy branch June 24, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up data_structure_dicts.py

3 participants