Ruff formatted available radial space for #4383#4423
Conversation
There was a problem hiding this comment.
I want to clarify to anyone reviewing what was going on here. Before this change the calculation for available radial space was essentially:
data.build.available_radial_space = (
data.stellarator.r_coil_minor * data.stellarator.f_coil_shape
- data.physics.rminor
)This bit of code was not doing anything and it was not changing the available_radial_space.
+data.stellarator_config.stella_config_derivative_min_lcfs_coils_dist * (
data.physics.rminor
- data.stellarator.f_st_rmajor * data.stellarator_config.stella_config_rminor_ref
)It would be good for someone with stellarator knowledge to confirm that this was a mistake @jjwalkowiak @grmtrkngtn
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
==========================================
- Coverage 48.85% 48.85% -0.01%
==========================================
Files 151 151
Lines 29390 29389 -1
==========================================
- Hits 14359 14358 -1
Misses 15031 15031 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
left a comment
There was a problem hiding this comment.
I'm happy with this change from a code perspective, but will wait for stellarator people to look and approve before merging, esp with the regression failures :)
|
These two parts are responsible for two different scaling of available space. Both are necessary. I think in the version I use both of them work. I can check again tomorrow. |
Description
Minor formatting change to remove Pylance warning.