Skip to content

Correct paths of existing regression tests in unit test docstrings#4426

Open
timothy-nunn wants to merge 5 commits into
mainfrom
4363-clean-up-references-to-old-test-files
Open

Correct paths of existing regression tests in unit test docstrings#4426
timothy-nunn wants to merge 5 commits into
mainfrom
4363-clean-up-references-to-old-test-files

Conversation

@timothy-nunn

Copy link
Copy Markdown
Collaborator

See the issue description for the references I can't correct (the files no longer, or never did, exist as regression tests).

@timothy-nunn
timothy-nunn requested a review from a team as a code owner July 9, 2026 13:59
@timothy-nunn timothy-nunn linked an issue Jul 9, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.63%. Comparing base (e9d8681) to head (44d8fc1).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4426      +/-   ##
==========================================
- Coverage   48.85%   48.63%   -0.22%     
==========================================
  Files         151      151              
  Lines       29390    29676     +286     
==========================================
+ Hits        14359    14434      +75     
- Misses      15031    15242     +211     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould self-assigned this Jul 9, 2026
@clmould

clmould commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Have discussed and will update the remaining files where possible to explain them (eg the pumping_2 is LT with different pumping model). Where this isn't possible, it will be made clear the file no longer exists in the PROCESS repo (but are available within the group)

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • test_pfcoil has 3 instances of 'baseline2019/baseline 2019', can these be fixed please

  • Could the updated refs have their line lengths fixed too please as they are quite long, -I think running the improve-quality-job should pick these up

  • Can these references also be tidied up please:
    Image

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things

Could you fix the 'line too long' errors when running hatch run lint:fmt_extra tests/ please

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be edited too please to state the file is no longer in the repo:

Image

Comment thread tests/unit/models/blankets/test_ccfe_hcpb.py Outdated
Comment thread tests/unit/models/tfcoil/test_tfcoil.py Outdated
Comment thread tests/unit/models/test_fw.py Outdated
@timothy-nunn
timothy-nunn requested a review from clmould July 17, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up references to old test files

3 participants