Skip to content

🐛 Prevent lower inequality constraint value from going outside the plot - #4432

Merged
clmould merged 2 commits into
mainfrom
4080-inequality-constraint-plotting-bars-overrunning-red-line
Jul 14, 2026
Merged

🐛 Prevent lower inequality constraint value from going outside the plot#4432
clmould merged 2 commits into
mainfrom
4080-inequality-constraint-plotting-bars-overrunning-red-line

Conversation

@chris-ashe

@chris-ashe chris-ashe commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Description

  • For lower limit constraints, the bar width is now set to 10 times the normalized value, but capped at a maximum of 1.0, preventing bars from extending excessively when the residual is large.
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe
chris-ashe requested a review from clmould July 13, 2026 10:21
@chris-ashe
chris-ashe requested a review from a team as a code owner July 13, 2026 10:21
@chris-ashe chris-ashe added Bug Something isnt working Plotting labels Jul 13, 2026
@chris-ashe chris-ashe linked an issue Jul 13, 2026 that may be closed by this pull request
@clmould clmould self-assigned this Jul 13, 2026
@codecov-commenter

codecov-commenter commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.63%. Comparing base (616f749) to head (e4abc9e).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4432      +/-   ##
==========================================
- Coverage   48.63%   48.63%   -0.01%     
==========================================
  Files         151      151              
  Lines       29673    29670       -3     
==========================================
- Hits        14432    14429       -3     
  Misses      15241    15241              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 small change but happy otherwise, looks better than having the bar go outside!

Comment thread process/core/io/plot/summary.py Outdated
normalised_value = con_residual_norm
bar_left = 0
bar_width = normalised_value
# Set the bar width to be 10 times the normalised value,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the bar width to be 10 times the normalised value,
# Set the bar width to be 1/10th of the normalised value,

@clmould
clmould merged commit c667257 into main Jul 14, 2026
36 of 44 checks passed
@clmould
clmould deleted the 4080-inequality-constraint-plotting-bars-overrunning-red-line branch July 14, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working Plotting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inequality constraint plotting bars overrunning red line

3 participants