stress_radial_cs_inner is very small when it should be 0 - #4436
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
+ Coverage 48.63% 48.64% +0.01%
==========================================
Files 151 151
Lines 29673 29677 +4
==========================================
+ Hits 14432 14437 +5
+ Misses 15241 15240 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timothy-nunn
marked this pull request as draft
July 13, 2026 14:11
chris-ashe
approved these changes
Jul 13, 2026
timothy-nunn
force-pushed
the
fix-flipflop-cs-stress
branch
from
July 14, 2026 10:15
fedf3f3 to
431eb5a
Compare
timothy-nunn
marked this pull request as ready for review
July 14, 2026 12:06
chris-ashe
approved these changes
Jul 14, 2026
calculate_cs_radial_stressstress_radial_cs_inner is very small when it should be 0
clmould
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the failures we have seen on main are from
stress_radial_cs_innerswitching between being a very small negative number or a very small positive number, both of which have the same absolute value. Changing the order of calculation incalculate_cs_radial_stresshas stopped this from occurring andstress_radial_cs_inneris now exactly0, which it should be.Edit: this has worked on Mac to make it exactly 0 but Linux machines still seem to find a very small value (+/- 9.486166219722724e-08). It is possible that this has at least stopped the negative-positive flip flop but that will require some testing.