Skip to content

stress_radial_cs_inner is very small when it should be 0 - #4436

Merged
clmould merged 1 commit into
mainfrom
fix-flipflop-cs-stress
Jul 14, 2026
Merged

stress_radial_cs_inner is very small when it should be 0#4436
clmould merged 1 commit into
mainfrom
fix-flipflop-cs-stress

Conversation

@timothy-nunn

@timothy-nunn timothy-nunn commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Some of the failures we have seen on main are from stress_radial_cs_inner switching between being a very small negative number or a very small positive number, both of which have the same absolute value. Changing the order of calculation in calculate_cs_radial_stress has stopped this from occurring and stress_radial_cs_inner is now exactly 0, which it should be.

Edit: this has worked on Mac to make it exactly 0 but Linux machines still seem to find a very small value (+/- 9.486166219722724e-08). It is possible that this has at least stopped the negative-positive flip flop but that will require some testing.

@timothy-nunn
timothy-nunn requested a review from a team as a code owner July 13, 2026 13:11
@timothy-nunn
timothy-nunn requested a review from chris-ashe July 13, 2026 13:12
@codecov-commenter

codecov-commenter commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.64%. Comparing base (616f749) to head (431eb5a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4436      +/-   ##
==========================================
+ Coverage   48.63%   48.64%   +0.01%     
==========================================
  Files         151      151              
  Lines       29673    29677       +4     
==========================================
+ Hits        14432    14437       +5     
+ Misses      15241    15240       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn marked this pull request as draft July 13, 2026 14:11
@clmould clmould self-assigned this Jul 13, 2026
@timothy-nunn
timothy-nunn force-pushed the fix-flipflop-cs-stress branch from fedf3f3 to 431eb5a Compare July 14, 2026 10:15
@timothy-nunn
timothy-nunn requested a review from chris-ashe July 14, 2026 12:06
@timothy-nunn
timothy-nunn marked this pull request as ready for review July 14, 2026 12:06
@timothy-nunn timothy-nunn changed the title Split up calculations in calculate_cs_radial_stress stress_radial_cs_inner is very small when it should be 0 Jul 14, 2026
@clmould
clmould merged commit 8efd34d into main Jul 14, 2026
8 of 11 checks passed
@clmould
clmould deleted the fix-flipflop-cs-stress branch July 14, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants