Skip to content

Add cable void variation in stellarator - #4455

Merged
timothy-nunn merged 4 commits into
ukaea:mainfrom
IPP-SRS:Add-cable-void-variation-in-stellarator
Jul 27, 2026
Merged

Add cable void variation in stellarator#4455
timothy-nunn merged 4 commits into
ukaea:mainfrom
IPP-SRS:Add-cable-void-variation-in-stellarator

Conversation

@jjwalkowiak

Copy link
Copy Markdown
Contributor

Description

I added an iteration variable to change the fraction of helium (also called void fraction) in the cable/winding pack. The reason behind this is that many stellarator builds are limited by the max B field on coils. To lower max B, PROCESS try to increase the coil cross-section. So far it was possible by increased copper fraction, which led to extremely long quench discharge times. To decouple quench time from max B on coil, I introduced an option to add more void to the cables.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@jjwalkowiak
jjwalkowiak requested a review from a team as a code owner July 22, 2026 11:42
@timothy-nunn
timothy-nunn requested a review from grmtrkngtn July 23, 2026 07:58
@timothy-nunn timothy-nunn self-assigned this Jul 23, 2026

@grmtrkngtn grmtrkngtn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread process/models/stellarator/build.py Outdated
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.63%. Comparing base (f95b094) to head (c5aba96).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
process/models/stellarator/build.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4455      +/-   ##
==========================================
- Coverage   48.82%   48.63%   -0.20%     
==========================================
  Files         151      151              
  Lines       29408    29706     +298     
==========================================
+ Hits        14359    14448      +89     
- Misses      15049    15258     +209     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn merged commit 7a6d754 into ukaea:main Jul 27, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants