Add sol outboard enum

[chris-ashe]

Description

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 52.77778% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (a3d041d) to head (c5597d4).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
process/models/physics/scrape_off_layer.py	5.88%	16 Missing ⚠️
process/models/physics/physics.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4514      +/-   ##
==========================================
+ Coverage   49.13%   49.32%   +0.19%     
==========================================
  Files         152      150       -2     
  Lines       29806    29802       -4     
==========================================
+ Hits        14644    14700      +56     
+ Misses      15162    15102      -60     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[timothy-nunn]

This block of code is not doing anything. Maybe just add a comment saying that OutbordSOLPowerDecayLengthModel.USER_INPUT would mean that len_sol_outboard_power_decay is already set to the user-input value

[chris-ashe]

Would you say keep the condition check just for verbosity and add a pass statement with a comment or just remove the whole condition check and just have the comment?

[timothy-nunn]

The latter, having 'useless' condition checks is a code smell. A comment will suffice