fix(done-check): narrow subagent-skip to formatting-only - #128
Merged
Conversation
The skip note listed "Pure renames" and "file moves with no content
change" as wasted overhead. But paired-artifact-drift is mechanical-lane
and its N/A criterion excludes "the diff renames / removes nothing" — and
it explicitly covers module-structure changes ("the moved file"). So a
pure rename or file move triggers it; skipping the subagent there skips
the one mechanical item the change itself requires.
Narrow the condition to formatting-only, mirroring todo-check's current
skip note (#126 made it coarse: formatting-only skips, everything else
dispatches, without enumerating what a rename triggers).
Closes #125.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe marketplace manifest version is updated to ChangesMarketplace manifest update
Done-check subagent rule
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).claude-plugin/marketplace.jsonTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 24, 2026
ultimatile
added a commit
that referenced
this pull request
Jul 24, 2026
) The skip path let both runners skip the mechanical-lane subagent on a formatting-only diff, on the premise that such a diff raises no mechanical concern. That premise is false: paired-artifact-drift's new-comment sweep, public-doc-durability's always-concern local-path rule, and ported-code-attribution's declared-port signal all key on the state of the touched text, not only what the diff newly introduces, so a formatting-only diff touching their surface can raise a real concern the skip would miss. Delete the skip path from both runners; the mechanical subagent is always dispatched. This subsumes the labeling bug the skip caused (mechanical rows marked N/A from lane tags, overriding item-body authority) with no new status token or downstream vocabulary change. Supersedes the skip machinery from #126 and #128. Closes #127.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
done-check's "When to skip the subagent" note skipped the mechanical-lane subagent on pure renames and file moves. Butpaired-artifact-driftis a mechanical-lane item whose N/A criterion excludes "the diff renames / removes nothing" and explicitly covers module-structure changes ("the moved file") — so a rename or file move is exactly the case that item exists to catch. Skipping the subagent there dropped the one mechanical check the change itself triggers.This narrows the skip condition to formatting-only (whitespace, list renumbering, table padding), matching
todo-check's current skip note. Anything else — a rename, signature, or doc change — now runs the subagent, which decides each item's applicability from the item's own body rather than the skip note trying to enumerate triggers.Closes #125.
Changes
skills/done-check/SKILL.md— narrow the "When to skip the subagent (step 2)" condition to formatting-only; drop the "pure renames" / "file moves" skip clause..claude-plugin/marketplace.json— version bump2026.7.23→2026.7.24.Notes
Scoped to the skip condition only. It does not change how the skip path fills the audit table's mechanical-lane rows when a diff is formatting-only; that question, together with a matching one in
todo-check, is tracked separately in #127.Summary by CodeRabbit
Chores
Documentation