fix(quality-list,todo-check): add validation-parity + ordering guards

[ultimatile]

Summary

When a diff adds a public entry that mirrors an existing sibling — a layout-dispatch trait impl, an auto-policy / explicit-policy pair, a parallel dense / block-sparse path — the gates checked structural and signature symmetry but not validation symmetry. Two real misses motivated this: a mirrored path that dropped a sibling's operand-rank check (silently returning an outer product), and an entry whose validator was sequenced after a panic-prone planner call (panicking instead of returning a semantic error). This extends the implementation-guards quality-list item to cover both, refining concerns it already owns rather than adding a new item.

Closes #30

Changes

• skills/quality-list/items/implementation-guards.md: add a "Mirrored-entry validation parity" paragraph (a new entry mirroring a sibling must replicate the sibling's full input-validation set, flagged even when the sibling's guard is not in the diff) and a "Validation precedes panic-prone operations" paragraph (input validation must not end up sequenced after a panic-prone operation on the same unvalidated input); add two matching Concern conditions; tighten the N/A clause to exclude both.
• skills/todo-check/SKILL.md: sync the implementation-guards preflight one-liner with the two new dimensions.
• .claude-plugin/marketplace.json: version bump.

Notes

public-api-surface was rejected as the home: its name scopes the public surface (signatures), while this is internal validation behavior. The checks stay in the mechanical lane — a new entry's guards diff against the reference sibling, and validation-vs-panic ordering, are both decidable from literal code without intent or execution. Issue #30 also floats a matching diff-time /code-review angle; that is out of scope here because /code-review is a built-in command, not authored in this repository.

Summary by CodeRabbit

• Documentation

  • Expanded guidance on validating inputs before error-prone operations, helping avoid crashes and surface clearer user-facing errors.
  • Added stronger checks for new matching entries so they mirror the full validation behavior of existing ones.
  • Clarified when a change can be considered out of scope for these checks.

• Chores

  • Updated plugin marketplace metadata to the latest version.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3195dea0-d21c-47a9-b39d-e5dde30b6268

📥 Commits

Reviewing files that changed from the base of the PR and between 7500237 and 92cb8d5.

📒 Files selected for processing (3)

• .claude-plugin/marketplace.json
• skills/quality-list/items/implementation-guards.md
• skills/todo-check/SKILL.md

---

📝 Walkthrough

Walkthrough

Updated marketplace metadata version and expanded implementation-guard guidance. The guidance now covers mirrored-entry validation parity, validation-before-panic ordering, and matching preflight reference text.

Changes

Validation guard guidance

Layer / File(s)	Summary
Guard guidance update skills/quality-list/items/implementation-guards.md, skills/todo-check/SKILL.md	Adds mirrored-entry validation parity and validation-before-panic conditions to the implementation-guards guidance, and mirrors the same text in the preflight reference row.

Marketplace metadata

Layer / File(s)	Summary
Version bump .claude-plugin/marketplace.json	Bumps metadata.version from 2026.6.35 to 2026.6.36.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A hop, a nibble, a careful glance,
I tuned the guards to guard their dance. 🐰
Mirrors match, and panics wait outside,
While version crumbs get one small ride.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding validation-parity and ordering guards to the quality-list and todo-check docs.
Linked Issues check	✅ Passed	The PR adds the mirrored-entry validation parity and validation-before-panic guards requested by issue #30 and updates the related reference text.
Out of Scope Changes check	✅ Passed	The only extra change is the marketplace version bump, which matches the PR scope and doesn't introduce unrelated behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/30-validation-parity

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}