Drop unused dependencies and ignore clone output - #22
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. This is an automated message, and an engineer will assist with any follow-up questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
The dependency cleanup and clone-output ignore rule are otherwise correct: run_repo.py uses GitPython and writes clones under ROOT / "github.com". Update the now-stale developer dependency documentation.
💬 Posted 1 inline comment
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Clean PR. The removed dependencies are not referenced by the repository, gitpython remains required by Repo.clone_from, and github.com/ correctly ignores the clone output produced under ROOT / "github.com".
|
🎉 Thank you @glenn-jocher for merging this thoughtful cleanup PR!
By removing unused dependencies, aligning contributor guidance, and preventing cloned repositories from entering version control, this change makes |
Follow-up to #21.
pyproject.tomldeclaredpandasandnumpyas runtime dependencies, but neither is imported anywhere in the repo — the only occurrence of either name is the string literal") -> np.ndarray:"insideIGNORE_LINESinsource/run_repo.py. Onlygitpythonis actually used (Repo.clone_from). Installing the package pulled in two large wheels for nothing..gitignoredid not cover the tool's own output.source/run_repo.py:132clones intoROOT / "github.com", so a single run leaves full clones of both compared repositories sitting untracked in the working tree. Addedgithub.com/, verified by creating the path and confirminggit statusstays clean.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🧹 Simplifies the
source-traceproject by removing unnecessary dependencies and excluding cloned repositories from version control.📊 Key Changes
pandasandnumpyfrom the required dependencies inpyproject.toml.AGENTS.mdto reflect thatgitpythonis now the only required dependency.github.com/to.gitignoreto exclude repositories cloned bysource/run_repo.py.🎯 Purpose & Impact
source-tracerepository.