Skip to content

Drop unused dependencies and ignore clone output - #22

Merged
glenn-jocher merged 2 commits into
mainfrom
drop-unused-deps
Aug 2, 2026
Merged

Drop unused dependencies and ignore clone output#22
glenn-jocher merged 2 commits into
mainfrom
drop-unused-deps

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Aug 2, 2026

Copy link
Copy Markdown
Member

Follow-up to #21.

  • pyproject.toml declared pandas and numpy as runtime dependencies, but neither is imported anywhere in the repo — the only occurrence of either name is the string literal ") -> np.ndarray:" inside IGNORE_LINES in source/run_repo.py. Only gitpython is actually used (Repo.clone_from). Installing the package pulled in two large wheels for nothing.
  • .gitignore did not cover the tool's own output. source/run_repo.py:132 clones into ROOT / "github.com", so a single run leaves full clones of both compared repositories sitting untracked in the working tree. Added github.com/, verified by creating the path and confirming git status stays clean.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

🧹 Simplifies the source-trace project by removing unnecessary dependencies and excluding cloned repositories from version control.

📊 Key Changes

  • Removed pandas and numpy from the required dependencies in pyproject.toml.
  • Updated AGENTS.md to reflect that gitpython is now the only required dependency.
  • Added github.com/ to .gitignore to exclude repositories cloned by source/run_repo.py.

🎯 Purpose & Impact

  • ⚡ Reduces installation time and project overhead by eliminating unused dependencies.
  • 📦 Makes the package lighter and easier to set up in development and deployment environments.
  • 🛡️ Prevents cloned repository contents from being accidentally committed to the source-trace repository.
  • ✅ Keeps contributor documentation aligned with the updated installation requirements.

@UltralyticsAssistant UltralyticsAssistant added dependencies Dependencies and packages devops GitHub Devops or MLops labels Aug 2, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/source-trace 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/source-trace main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. This is an automated message, and an engineer will assist with any follow-up questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

The dependency cleanup and clone-output ignore rule are otherwise correct: run_repo.py uses GitPython and writes clones under ROOT / "github.com". Update the now-stale developer dependency documentation.

💬 Posted 1 inline comment

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Clean PR. The removed dependencies are not referenced by the repository, gitpython remains required by Repo.clone_from, and github.com/ correctly ignores the clone output produced under ROOT / "github.com".

@glenn-jocher
glenn-jocher merged commit fe7f3e9 into main Aug 2, 2026
6 checks passed
@glenn-jocher
glenn-jocher deleted the drop-unused-deps branch August 2, 2026 18:29
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 Thank you @glenn-jocher for merging this thoughtful cleanup PR!

“Simplicity is the ultimate sophistication.” — Leonardo da Vinci

By removing unused dependencies, aligning contributor guidance, and preventing cloned repositories from entering version control, this change makes source-trace lighter, cleaner, and easier to maintain. Your attention to these details helps keep the project efficient and contributor-friendly—great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependencies and packages devops GitHub Devops or MLops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants