Skip to content

fix: make cc2 renderer path errors concise - #3180

Merged
code-yeongyu merged 1 commit into
mainfrom
fix/cc2-renderer-path-errors
May 28, 2026
Merged

fix: make cc2 renderer path errors concise#3180
code-yeongyu merged 1 commit into
mainfrom
fix/cc2-renderer-path-errors

Conversation

@Yeachan-Heo

Copy link
Copy Markdown
Contributor

Summary

  • replace CC2 renderer tracebacks for directory board JSON, invalid board JSON, and directory markdown paths with concise ERROR: messages
  • preserves successful render/check behavior

Validation

  • python3 .omx/cc2/render_board_md.py /tmp/cc2-render-0200/board-json-dir /tmp/cc2-render-0200/out.md
  • python3 .omx/cc2/render_board_md.py /tmp/cc2-render-0200/bad.json /tmp/cc2-render-0200/out.md
  • python3 .omx/cc2/render_board_md.py .omx/cc2/board.json /tmp/cc2-render-0200/out-md-dir
  • python3 .omx/cc2/render_board_md.py .omx/cc2/board.json /tmp/cc2-render-0200/out-md-dir --check
  • python3 .omx/cc2/render_board_md.py .omx/cc2/board.json /tmp/cc2-render-0200/out.md
  • python3 .omx/cc2/render_board_md.py .omx/cc2/board.json /tmp/cc2-render-0200/out.md --check
  • python3 scripts/cc2_board.py validate


[repo owner's gaebal-gajae (clawdbot) 🦞]

@code-yeongyu
code-yeongyu merged commit 3260258 into main May 28, 2026
1 check passed
@code-yeongyu
code-yeongyu deleted the fix/cc2-renderer-path-errors branch May 28, 2026 02:08
@1716775457damn

Copy link
Copy Markdown

Replacing renderer tracebacks with concise ERROR messages is a good UX improvement — users don't need to see Python stack traces for predictable error paths.

@raied369 raied369 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raied369

@1716775457damn

Copy link
Copy Markdown

Thanks for the review @raied369. The error messages are much cleaner now. One question for @Yeachan-Heo: does this also handle the case where board.json is missing entirely (not just invalid JSON)? That edge case might still produce a raw traceback.

@1716775457damn

Copy link
Copy Markdown

Clean improvement. The concise ERROR messages are much more user-friendly than raw Python tracebacks. Would suggest also considering a --verbose flag to optionally surface full tracebacks for debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants