feat(tools): add timeout control for web fetch - #3282
Closed
AbdullahFageeh wants to merge 1 commit into
Closed
Conversation
Add optional timeout_ms for WebFetch requests, apply timeout-specific error handling, and cover the behavior with a timeout-focused unit test. Co-Authored-By: Oz <oz-agent@warp.dev>
|
Good addition. Timeout control for web fetch is essential when dealing with unreliable endpoints — without it, a hung request can block the entire agent workflow. The implementation looks clean with proper timeout-specific error handling. One suggestion: consider documenting the default timeout value in the tool description so callers know what to expect when they omit imeout_ms. |
|
Timeout control for web fetch is a practical addition. The timeout-specific error handling makes it easy to distinguish network timeouts from other fetch failures in calling code. One suggestion: consider documenting the default timeout behavior in the config reference so users understand what happens without explicitly setting timeout_ms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional timeout_ms for WebFetch requests, apply timeout-specific error handling, and cover the behavior with a timeout-focused unit test.
Summary
Anti-slop triage
Verification
git diff --checkpasses.Resolution gate