Skip to content

feat(tools): add timeout control for web fetch - #3282

Closed
AbdullahFageeh wants to merge 1 commit into
ultraworkers:mainfrom
AbdullahFageeh:oz/webfetch-timeout
Closed

feat(tools): add timeout control for web fetch#3282
AbdullahFageeh wants to merge 1 commit into
ultraworkers:mainfrom
AbdullahFageeh:oz/webfetch-timeout

Conversation

@AbdullahFageeh

@AbdullahFageeh AbdullahFageeh commented Jul 31, 2026

Copy link
Copy Markdown

Add optional timeout_ms for WebFetch requests, apply timeout-specific error handling, and cover the behavior with a timeout-focused unit test.

Summary

  • TBD

Anti-slop triage

  • Classification:
  • Evidence:
  • Non-destructive review result:

Verification

  • Targeted tests/docs checks ran, or the gap is explicitly recorded.
  • git diff --check passes.
  • No live secrets, tokens, private logs, or unrelated generated churn are included.

Resolution gate

  • If this PR resolves an issue, the issue number and fix evidence are linked.
  • If this PR should not merge, the rejection/defer rationale is evidence-backed and does not rely on vibes.
  • I did not merge/close remote PRs or issues from an automation lane without owner approval.

Add optional timeout_ms for WebFetch requests, apply timeout-specific error handling, and cover the behavior with a timeout-focused unit test.

Co-Authored-By: Oz <oz-agent@warp.dev>
@1716775457damn

Copy link
Copy Markdown

Good addition. Timeout control for web fetch is essential when dealing with unreliable endpoints — without it, a hung request can block the entire agent workflow. The implementation looks clean with proper timeout-specific error handling. One suggestion: consider documenting the default timeout value in the tool description so callers know what to expect when they omit imeout_ms.

@1716775457damn

Copy link
Copy Markdown

Timeout control for web fetch is a practical addition. The timeout-specific error handling makes it easy to distinguish network timeouts from other fetch failures in calling code. One suggestion: consider documenting the default timeout behavior in the config reference so users understand what happens without explicitly setting timeout_ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants