-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Issue U4-5231 - Created an interface based on the LogService to replace LogHelper #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ted a service, exposed through Application.Services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should simplify the ILoggingService interface. Anything that has a generic call in it can be an extension method. We should keep this interface as simple as possible.
There's quite a few methods in the LogHelper that are there just for legacy/backwards compatibility reasons, moving forward we shouldn't have them. Any method with the 'showHttpTrace' should not exist on this interface (we can deal with that internally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shazwazza showHttpTrace is still important for people still using webforms, where umbDebugShowTrace still works just fine.
|
This will also need to be targeted at 7.2, but i can take care of that in the merge i think. |
|
I've removed the items from the interface. I've left the methods in the Service though, as I noticed that if you want to port code to use it, there are a few cases where you might need them. |
|
Coming back to this PR, there's a few things that need to be adjusted... I'll do the following but myself when i pull this in but I'm just writing what needs to be done for completeness:
|
Created an interface based on the LogHelper, and created a service, exposed through Application.Services. Made LogHelper obsolete.
http://issues.umbraco.org/issue/U4-5231
Assisted by @cloud46limited